netdev - Re: [PATCH net-next 0/4] selftests: fib_tests: simplifications, verbosity and a race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180213.143448.27158523498798506.davem@davemloft.net>
Date:   Tue, 13 Feb 2018 14:34:48 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org, idosch@...lanox.com
Subject: Re: [PATCH net-next 0/4] selftests: fib_tests: simplifications,
 verbosity and a race

From: David Ahern <dsahern@...il.com>
Date: Tue, 13 Feb 2018 08:37:32 -0800

> Improve efficiency of fib_tests.sh and make the test result more verbose,
> from this summary:
> $ fib_tests.sh is failing in a VM:
>     $ fib_tests.sh
>     Running netdev unregister tests
>     PASS: unicast route test
>     PASS: multipath route test
>     Running netdev down tests
>     PASS: unicast route test
>     PASS: multipath route test
>     Running netdev carrier change tests
>     PASS: local route carrier test
>     FAIL: unicast route carrier test
> 
> where a single entry actually corresponds to many checks to a much more
> verbse output that clarifies test cases:
> $fib_tests.sh
> Single path route carrier test
>     ....
>     Carrier down
>         IPv4 fibmatch                                         [ OK ]
>         IPv6 fibmatch                                         [ OK ]
>         IPv4 linkdown flag set                                [FAIL]
>         IPv6 linkdown flag set                                [FAIL]
>     Second address added with carrier down
>         IPv4 fibmatch                                         [ OK ]
>         IPv6 fibmatch                                         [ OK ]
>         IPv4 linkdown flag set                                [FAIL]
>         IPv6 linkdown flag set                                [ OK ]
> 
> And then fix the race in changing carrier down on dummy device to checking
> the corresponding routes.

Looks great, series applied, thanks David.