lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Feb 2018 20:54:10 +0000 From: "Brown, Aaron F" <aaron.f.brown@...el.com> To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com> CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org> Subject: RE: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON > From: netdev-owner@...r.kernel.org [mailto:netdev- > owner@...r.kernel.org] On Behalf Of Christophe JAILLET > Sent: Tuesday, February 6, 2018 11:48 AM > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com> > Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux- > kernel@...r.kernel.org; kernel-janitors@...r.kernel.org; Christophe > JAILLET <christophe.jaillet@...adoo.fr> > Subject: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON > > 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. > The modified code should behave the same, because HWTSTAMP_TX_ON is > 1 > and no other possible values of 'tx_type' would match the test. > However, this is more future-proof, should other values be allowed one day. > > See 'struct hwtstamp_config' in 'include/uapi/linux/net_tstamp.h' > > This fixes a warning reported by smatch: > igb_xmit_frame_ring() warn: bit shifter 'HWTSTAMP_TX_ON' used for > logical '&' > > Fixes: 26bd4e2db06be ("igb: protect TX timestamping from API misuse") > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> > --- > drivers/net/ethernet/intel/igb/igb_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Aaron Brown <aaron.f.brown@...el.com>
Powered by blists - more mailing lists