netdev - Re: [PATCH v1 net-next 2/3] lan743x: Update Kconfig and Makefile to include lan743x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Feb 2018 15:53:03 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Bryan Whitehead <Bryan.Whitehead@...rochip.com>,
        davem@...emloft.net
Cc:     UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 2/3] lan743x: Update Kconfig and Makefile to
 include lan743x driver

On 02/13/2018 03:26 PM, Bryan Whitehead wrote:
> Update Kconfig and Makefile to include lan743x driver.

This should be squashed into the first patch, otherwise the first patch
introduces non buildable code, which is kind of pointless.

> 
> Signed-off-by: Bryan Whitehead <Bryan.Whitehead@...rochip.com>
> ---
>  drivers/net/ethernet/microchip/Kconfig  | 9 +++++++++
>  drivers/net/ethernet/microchip/Makefile | 3 +++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig
> index 36a09d9..0c6955f 100644
> --- a/drivers/net/ethernet/microchip/Kconfig
> +++ b/drivers/net/ethernet/microchip/Kconfig
> @@ -42,4 +42,13 @@ config ENCX24J600
>        To compile this driver as a module, choose M here. The module will be
>        called encx24j600.
>  
> +config LAN743X
> +	tristate "LAN743x support"
> +	depends on PCI

There should probably be a select PHYLIB here since you use struct
mii_bus and the PHY library.
-- 
Florian