netdev - Re: [PATCH ipsec] xfrm_user: uncoditionally validate esn replay attribute struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180214114606.cntjjzqtlx3gewhb@gauss3.secunet.de>
Date:   Wed, 14 Feb 2018 12:46:06 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Florian Westphal <fw@...len.de>
CC:     <netdev@...r.kernel.org>, <syzkaller-bugs@...glegroups.com>,
        "Mathias Krause" <minipli@...glemail.com>
Subject: Re: [PATCH ipsec] xfrm_user: uncoditionally validate esn replay
 attribute struct

On Mon, Feb 12, 2018 at 02:42:01PM +0100, Florian Westphal wrote:
> The sanity test added in ecd7918745234 can be bypassed, validation
> only occurs if XFRM_STATE_ESN flag is set, but rest of code doesn't care
> and just checks if the attribute itself is present.
> 
> So always validate.  Alternative is to reject if we have the attribute
> without the flag but that would change abi.
> 
> Reported-by: syzbot+0ab777c27d2bb7588f73@...kaller.appspotmail.com
> Cc: Mathias Krause <minipli@...glemail.com>
> Fixes: ecd7918745234 ("xfrm_user: ensure user supplied esn replay window is valid")
> Fixes: d8647b79c3b7e ("xfrm: Add user interface for esn and big anti-replay windows")
> Signed-off-by: Florian Westphal <fw@...len.de>

Patch applied, thanks Florian!