netdev - Re: [PATCH] ss: prepare rth when killing inet sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Feb 2018 07:25:27 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Masatake YAMATO <yamato@...hat.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] ss: prepare rth when killing inet sock

On Wed, 14 Feb 2018 22:50:04 +0900
Masatake YAMATO <yamato@...hat.com> wrote:

> kill_inet_sock() expects rhn_handle instance is passed
> via inet_diag_arg argument. However on the following calling path:
> 
>     generic_show_sock
>     => show_one_inet_sock
>        => kill_inet_sock  
> 
> rth field of inet_diag_arg is not filled with the address of
> rhn_handle instance. As the result ss crashes.
> 
> This commit fills the field with newly created rhn_handle
> instance.
> 
> Signed-off-by: Masatake YAMATO <yamato@...hat.com>

Won't this slow down ss because it does open/close of netlink socket
for each socket being displayed.  It is not uncommon to run this with
millions of sockets open.