netdev - Re: [PATCH net] fib_semantics: Don't match route with mismatching tclassid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Feb 2018 19:06:37 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     David Ahern <dsahern@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Thomas Graf <tgraf@...g.ch>, Jianlin Shi <jishi@...hat.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] fib_semantics: Don't match route with mismatching
 tclassid

Hi David,

On Wed, 14 Feb 2018 10:46:05 -0700
David Ahern <dsahern@...il.com> wrote:

> On 2/14/18 10:28 AM, Stefano Brivio wrote:
>
> > +#ifdef CONFIG_IP_ROUTE_CLASSID
> > +		if (cfg->fc_flow != fi->fib_nh->nh_tclassid)
> > +			return 1;
> > +#endif  
> 
> you should verify fc_flow is set. user is allowed to delete first
> matching route based on data that is given.

Thanks for your comment.

My intended semantic was different, that is, I assumed that if fc_flow
is not set (zero, here), the user shouldn't be able to just delete the
first matching route. But I guess your interpretation makes more sense
because it's consistent with the other checks. I'll send a v2.

-- 
Stefano