netdev - Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180214.140256.2107383260203156183.davem@davemloft.net>
Date:   Wed, 14 Feb 2018 14:02:56 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sowmini.varadhan@...cle.com
Cc:     santosh.shilimkar@...cle.com, netdev@...r.kernel.org,
        willemdebruijn.kernel@...il.com, rds-devel@....oracle.com
Subject: Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion
 notification

From: Sowmini Varadhan <sowmini.varadhan@...cle.com>
Date: Wed, 14 Feb 2018 14:01:10 -0500

> On (02/14/18 10:50), Santosh Shilimkar wrote:
>> generic comment and please update it where it is applicable
>> in terms of variable names, notifiers etc.
>> 
>> RDS support true zero copy already with RDMA transport so some of
>> this code can easily get confused.
>> 
>> So I suggest something like below.
>> s/zerocopy/zeromsgcopy
>> s/zcopy/zmsgcopy
>> s/zcookie/zmsgcpycookie
>> s/znotifier/zmsgcpynotifier	
> 
> I'd like to hear some additional opinions from the list on this: 
> the existing socket API for TCP etc.  already uses ZEROCOPY, and other
> than extending variable names (and putting me at risk of violating the
> "fit within 80 chars per line" requirement, leading to not-so-pretty
> line wraps), I'm not seeing much value in this.

I agree, this name change requires seems pointless.  Just keep the names
the way they are, thank you.