netdev - Re: [net PATCH] Revert "net: thunderx: Add support for xdp redirect"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180214.142403.532212436685780119.davem@davemloft.net>
Date:   Wed, 14 Feb 2018 14:24:03 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     brouer@...hat.com
Cc:     netdev@...r.kernel.org, sgoutham@...ium.com,
        aleksey.makarov@...ium.com, alexei.starovoitov@...il.com,
        cjacob@...iumnetworks.com, borkmann@...earbox.net,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [net PATCH] Revert "net: thunderx: Add support for xdp
 redirect"

From: Jesper Dangaard Brouer <brouer@...hat.com>
Date: Tue, 13 Feb 2018 17:59:22 +0100

> This reverts commit aa136d0c82fcd6af14535853c30e219e02b2692d.
> 
> As I previously[1] pointed out this implementation of XDP_REDIRECT is
> wrong.  XDP_REDIRECT is a facility that must work between different
> NIC drivers.  Another NIC driver can call ndo_xdp_xmit/nicvf_xdp_xmit,
> but your driver patch assumes payload data (at top of page) will
> contain a queue index and a DMA addr, this is not true and worse will
> likely contain garbage.
> 
> Given you have not fixed this in due time (just reached v4.16-rc1),
> the only option I see is a revert.
> 
> [1] http://lkml.kernel.org/r/20171211130902.482513d3@redhat.com
> 
> Cc: Sunil Goutham <sgoutham@...ium.com>
> Cc: Christina Jacob <cjacob@...iumnetworks.com>
> Cc: Aleksey Makarov <aleksey.makarov@...ium.com>
> Fixes: aa136d0c82fc ("net: thunderx: Add support for xdp redirect")
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>

Applied, thanks Jesper.