netdev - [vhost:vhost 24/24] drivers/firmware/qemu_fw_cfg.c:499:22: error: storage size of 'files' isn't known

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <201802150430.8hqex8Tw%fengguang.wu@intel.com>
Date:   Thu, 15 Feb 2018 04:27:33 +0800
From:   kbuild test robot <fengguang.wu@...el.com>
To:     Marc-André Lureau <marcandre.lureau@...hat.com>
Cc:     kbuild-all@...org, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        "Michael S. Tsirkin" <mst@...hat.com>
Subject: [vhost:vhost 24/24] drivers/firmware/qemu_fw_cfg.c:499:22: error:
 storage size of 'files' isn't known

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head:   5d457fe6aeaab9d0a1665eafc8af7139bc6b6f2e
commit: 5d457fe6aeaab9d0a1665eafc8af7139bc6b6f2e [24/24] fw_cfg: fix sparse warnings around FW_CFG_FILE_DIR read
config: i386-randconfig-x015-201806 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        git checkout 5d457fe6aeaab9d0a1665eafc8af7139bc6b6f2e
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/firmware/qemu_fw_cfg.c: In function 'fw_cfg_register_dir_entries':
>> drivers/firmware/qemu_fw_cfg.c:499:22: error: storage size of 'files' isn't known
     struct fw_cfg_files files;
                         ^~~~~
   drivers/firmware/qemu_fw_cfg.c:499:22: warning: unused variable 'files' [-Wunused-variable]

vim +499 drivers/firmware/qemu_fw_cfg.c

   493	
   494	/* iterate over all fw_cfg directory entries, registering each one */
   495	static int fw_cfg_register_dir_entries(void)
   496	{
   497		int ret = 0;
   498		u32 count, i;
 > 499		struct fw_cfg_files files;
   500		struct fw_cfg_file *dir;
   501		size_t dir_size;
   502	
   503		fw_cfg_read_blob(FW_CFG_FILE_DIR, &files.count, 0, sizeof(files.count));
   504		count = be32_to_cpu(files.count);
   505		dir_size = count * sizeof(struct fw_cfg_file);
   506	
   507		dir = kmalloc(dir_size, GFP_KERNEL);
   508		if (!dir)
   509			return -ENOMEM;
   510	
   511		fw_cfg_read_blob(FW_CFG_FILE_DIR, dir, sizeof(files.count), dir_size);
   512	
   513		for (i = 0; i < count; i++) {
   514			ret = fw_cfg_register_file(&dir[i]);
   515			if (ret)
   516				break;
   517		}
   518	
   519		kfree(dir);
   520		return ret;
   521	}
   522	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32274 bytes)