netdev - Re: [PATCH] ip_tunnel: Use mark in skb by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1518643569155.7361@alliedtelesis.co.nz>
Date:   Wed, 14 Feb 2018 21:26:09 +0000
From:   Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kuznet@....inr.ac.ru" <kuznet@....inr.ac.ru>,
        "yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH] ip_tunnel: Use mark in skb by default

Hello David Miller,

Would this patch be able to be reverted? We have found in further testing that this produces undesired results.

For example, using some PBR rule that uses conntrack to set the skb->mark and the desired nexthop is a tunnel then the tunnel route selection hits a routing loop as the skb->mark is the mark of the encapsulated traffic and route selected by init_tunnel_flow is via tunnel itself.

Regards,
Thomas Winter
________________________________________
From: David Miller <davem@...emloft.net>
Sent: 25 January 2018 10:31
To: Thomas Winter
Cc: netdev@...r.kernel.org; kuznet@....inr.ac.ru; yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] ip_tunnel: Use mark in skb by default

From: Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>
Date: Tue, 23 Jan 2018 16:46:24 +1300

> This allows marks set by connmark in iptables
> to be used for route lookups.
>
> Signed-off-by: Thomas Winter <thomas.winter@...iedtelesis.co.nz>

Applied to net-next, thanks.