netdev - Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180214220851.k4ce6ha6bjj6gby2@darkstar.musicnaut.iki.fi>
Date:   Thu, 15 Feb 2018 00:08:51 +0200
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     Sowmini Varadhan <sowmini.varadhan@...cle.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        willemdebruijn.kernel@...il.com, rds-devel@....oracle.com
Subject: Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion
 notification

On 2/14/2018 1:25 PM, Sowmini Varadhan wrote:
> On (02/14/18 13:10), Santosh Shilimkar wrote:
>>>>> RDS support true zero copy already with RDMA transport so some of
>>>>> this code can easily get confused.
> 
> btw, another way to solve this is to have the RDMA code use the
> suffix "rdma" (which is what it really is) as needed.
> 
And same breath,here zcopy is No message from user ;-)
ZCOPY is otherwise often tied with RDMA directly.

Renaming churns are not that useful and I definitely agree
with what Dave said if it was renaming change to the
existing code like what you are suggesting with 'rdma'

Anyways I don't want to contest this too much since I can
follow that code and know what each does and means :-)

The comment was long term readability perspective for
some one completely new reading the code and being able to
distinguish the different modes.

Regards,
Santosh