netdev - Re: [bpf-next PATCH] selftests/bpf: fix Makefile for cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180214020413.5b47twcitynbkn3a@ast-mbp.dhcp.thefacebook.com>
Date:   Tue, 13 Feb 2018 18:04:14 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     netdev@...r.kernel.org, Roman Gushchin <guro@...com>,
        Daniel Borkmann <borkmann@...earbox.net>
Subject: Re: [bpf-next PATCH] selftests/bpf: fix Makefile for cgroup_helpers.c

On Tue, Feb 13, 2018 at 02:19:15PM +0100, Jesper Dangaard Brouer wrote:
> The current selftests Makefile construct result in cgroup_helpers.c
> gets compiled together with all the TEST_GEN_PROGS. And it also result
> in invoking the libbpf Makefile two times (tools/lib/bpf).
> 
> These issues were introduced in commit 9d1f15941967 ("bpf: move
> cgroup_helpers from samples/bpf/ to tools/testing/selftesting/bpf/").
> 
> The only test program that requires the cgroup helpers is 'test_dev_cgroup'.
> 
> Thus, create a make target $(OUTPUT)/test_dev_cgroup that extend[1]
> the 'prerequisite' for the 'stem' %-style pattern in ../lib.mk,
> for this particular test program.
> 
> Reviewers notice the make-rules in tools/testing/selftests/lib.mk
> differ from the normal kernel kbuild rules, and it is practical
> to use 'make -p' to follow how these 'Implicit/static pattern stem'
> gets expanded.
> 
> [1] https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
> 
> Fixes: 9d1f15941967 ("bpf: move cgroup_helpers from samples/bpf/ to tools/testing/selftesting/bpf/")
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>

Applied to bpf-next, Thanks Jesper.