netdev - Re: [PATCH bpf-next] bpf: fix sock_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <743b55fe-6633-445c-4ab2-68281a4b9387@gmail.com>
Date:   Tue, 13 Feb 2018 18:53:36 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>,
        Eric Dumazet <eric.dumazet@...il.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: fix sock_map_alloc() error path

On 02/13/2018 05:19 PM, Daniel Borkmann wrote:
> Hi Eric,
> 
> On 02/14/2018 12:43 AM, Eric Dumazet wrote:
>> On Tue, 2018-02-13 at 15:33 -0800, Eric Dumazet wrote:
>>> From: Eric Dumazet <edumazet@...gle.com>
>>>
>>> In case user program provides silly parameters, we want
>>> a map_alloc() handler to return an error, not a NULL pointer,
>>> otherwise we crash later in find_and_alloc_map()
>>>
>>> Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support")
>>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>>> Reported-by: syzbot <syzkaller@...glegroups.com>
>>> ---

Thanks Eric, also great to see syzkaller working on the sockmap
types.

Acked-by: John Fastabend <john.fastabend@...il.com>

>>
>> This would apply to net or bpf trees, not -next ones, sorry for the
>> confusion in the [PATCH bpf-next] prefix.
> 
> No problem, thanks for the fix!
> 
>> Bug was added in 4.14
> 
> Fixes tag is actually slightly different, it would be:
> 
> Fixes: 1aa12bdf1bfb ("bpf: sockmap, add sock close() hook to remove socks")
> 

Yep.

> I can change it if you want, no need to resend.> Thanks,
> Daniel
>