netdev - Re: [PATCH net] net: sched: fix unbalance in the error path of tca_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <216a671c-f8ec-b53e-dec0-bae8ba94fac0@mojatatu.com>
Date:   Thu, 15 Feb 2018 10:31:51 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Davide Caratti <dcaratti@...hat.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Cong Wang <xiyou.wangcong@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net: sched: fix unbalance in the error path of
 tca_action_flush()

On 18-02-15 09:50 AM, Davide Caratti wrote:
> When tca_action_flush() calls the action walk() and gets an error,
> a successful call to nla_nest_start() is not followed by a call to
> nla_nest_cancel(). It's harmless, as the skb is freed in the error
> path - but it's worth to fix this unbalance.

Kind of pushing the boundaries saying this targets net tree - there is
no bug you are fixing (as you say the sk is freed).
Maybe it makes the code prettier ...

cheers,
jamal