netdev - Re: [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <102e09cf-a090-d6c2-8b10-5190644203cc@embeddedor.com>
Date:   Thu, 15 Feb 2018 12:38:54 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     jeffrey.t.kirsher@...el.com,
        "Ramamurthy, Harshitha" <harshitha.ramamurthy@...el.com>,
        David Miller <davem@...emloft.net>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: Re: [PATCH] i40evf/i40evf_main: Fix variable assignment in
 i40evf_parse_cls_flower



On 02/15/2018 12:11 PM, Jeff Kirsher wrote:
> On Thu, 2018-02-15 at 09:56 -0800, Ramamurthy, Harshitha wrote:
>> On Thu, 2018-02-15 at 11:44 -0600, Gustavo A. R. Silva wrote:
>>> It seems this is a copy-paste error and that the proper variable to
>>> use
>>> in this particular case is _src_ instead of _dst_.
>>>
>>> Addresses-Coverity-ID: 1465282 ("Copy-paste error")
>>> Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>>
>> Thanks for the patch!
>>

Glad to help. :)

>> Acked-by:Harshitha Ramamurthy <harshitha.ramamurthy@...el.com>
> 
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> Dave, no need for me to pick this patch up and then push to you.  You
> can circumvent me and pick this up.
> 
>>> ---
>>>   drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)

Thanks guys.
--
Gustavo