netdev - Re: [PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Feb 2018 09:35:51 +0200
From:   Luciano Coelho <luciano.coelho@...el.com>
To:     Ulf Magnusson <ulfalizer@...il.com>, linux-kernel@...r.kernel.org
Cc:     linux-kbuild@...r.kernel.org, tfiga@...omium.org,
        paul.burton@...s.com, m.szyprowski@...sung.com,
        egtvedt@...fundet.no, linus.walleij@...aro.org,
        vgupta@...opsys.com, mgorman@...hsingularity.net, hch@....de,
        mina86@...a86.com, robh@...nel.org, sboyd@...eaurora.org,
        paulus@...abs.org, will.deacon@....com, tony@...mide.com,
        npiggin@...il.com, yamada.masahiro@...ionext.com,
        Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM
 default

On Mon, 2018-02-05 at 02:21 +0100, Ulf Magnusson wrote:
> 'default false' should be 'default n', though they happen to have the
> same effect here, due to undefined symbols ('false' in this case)
> evaluating to n in a tristate sense.
> 
> Remove the default instead of changing it. bool and tristate symbols
> implicitly default to n.
> 
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_und
> efined.py
> script.
> 
> Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
> ---

Thanks, Ulf!

This is applied in our internal tree and will eventually reach the
mainline, following our usual upstreaming process.

--
Cheers,
Luca.