netdev - Re: [PATCH iproute2 2/7] devlink: mnlg: Add support for extended ack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <078d8eaa-da4a-3c4c-0d82-817c3dd72a9a@mellanox.com>
Date:   Thu, 15 Feb 2018 13:57:18 +0200
From:   Arkadi Sharshevsky <arkadis@...lanox.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        dsa@...ulusnetworks.com, mlxsw@...lanox.com,
        Jiri Pirko <jiri@...lanox.com>
Subject: Re: [PATCH iproute2 2/7] devlink: mnlg: Add support for extended ack



On 02/14/2018 05:12 PM, Stephen Hemminger wrote:
> On Wed, 14 Feb 2018 10:55:17 +0200
> Arkadi Sharshevsky <arkadis@...lanox.com> wrote:
> 
>> +static mnl_cb_t mnlg_cb_array[NLMSG_MIN_TYPE] = {
>> +	[NLMSG_NOOP]	= mnlg_cb_noop,
>> +	[NLMSG_ERROR]	= mnlg_cb_error,
>> +	[NLMSG_DONE]	= mnlg_cb_stop,
>> +	[NLMSG_OVERRUN]	= mnlg_cb_noop,
>> +};
>> +
> 
> Could be const?
> 

I pass the array to mnl_cb_run2() which will discard the 'const'
qualifier. So I dont think this is very beneficial.