netdev - Re: [PATCH] net: sched: tbf: handle GSO_BY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wozenw8h.fsf@linkitivity.dja.id.au>
Date:   Fri, 16 Feb 2018 01:49:50 +1100
From:   Daniel Axtens <dja@...ens.net>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue

Hi Marcelo,

>
> If this block was meant to be an out-of-band/changelog comment, your
> SOB line should be above the first --- marker.
> Anyhow,
> Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

Thanks - I did a v2 with this around the right way [1], but DaveM asked
me to be a bit more thorough and look for other GSO_BY_FRAGS issues. [2]

I did find a couple, including the one I asked you about with
qdisk_pkt_len_init [3] (thanks for your answer, btw). Currently I'm
trying to wrap my head around GSO_DODGY as Eric mentioned on that
thread, and then I'll do a series with this fix and the other
GSO_BY_FRAGS fixes I find.

Regards,
Daniel

[1] https://patchwork.ozlabs.org/patch/869145/
[2] https://patchwork.ozlabs.org/comment/1852414/
[3] https://www.spinics.net/lists/netdev/msg482397.html
>
>> ---
>>  net/sched/sch_tbf.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c
>> index 229172d509cc..03225a8df973 100644
>> --- a/net/sched/sch_tbf.c
>> +++ b/net/sched/sch_tbf.c
>> @@ -188,7 +188,8 @@ static int tbf_enqueue(struct sk_buff *skb, struct Qdisc *sch,
>>  	int ret;
>>  
>>  	if (qdisc_pkt_len(skb) > q->max_size) {
>> -		if (skb_is_gso(skb) && skb_gso_mac_seglen(skb) <= q->max_size)
>> +		if (skb_is_gso(skb) &&
>> +		    skb_gso_validate_mac_len(skb, q->max_size))
>>  			return tbf_segment(skb, sch, to_free);
>>  		return qdisc_drop(skb, sch, to_free);
>>  	}
>> -- 
>> 2.14.1
>>