netdev - Re: [PATCH net] tg3: APE heartbeat changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180216.162614.1942583835571640040.davem@davemloft.net>
Date:   Fri, 16 Feb 2018 16:26:14 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     satish.baddipadige@...adcom.com
Cc:     netdev@...r.kernel.org, michael.chan@...adcom.com,
        prashant@...adcom.com, siva.kallam@...adcom.com,
        prashant.sreedharan@...adcom.com
Subject: Re: [PATCH net] tg3: APE heartbeat changes

From: Satish Baddipadige <satish.baddipadige@...adcom.com>
Date: Fri, 16 Feb 2018 10:01:29 +0530

> @@ -990,6 +984,18 @@ static void tg3_ape_driver_state_change(struct tg3 *tp, int kind)
>  	tg3_ape_send_event(tp, event);
>  }
>  
> +static inline void tg3_send_ape_heartbeat(struct tg3 *tp,

Inline functions are not appropriate in foo.c files, please drop the
inline keyword and let the compiler device.