netdev - Re: [PATCH net] sctp: remove the left unnecessary check for chunk in sctp_renege

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180216122612.GA10040@hmswarspite.think-freely.org>
Date:   Fri, 16 Feb 2018 07:26:12 -0500
From:   Neil Horman <nhorman@...driver.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        davem@...emloft.net,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH net] sctp: remove the left unnecessary check for chunk in
 sctp_renege_events

On Fri, Feb 16, 2018 at 05:18:33PM +0800, Xin Long wrote:
> Commit fb23403536ea ("sctp: remove the useless check in
> sctp_renege_events") forgot to remove another check for
> chunk in sctp_renege_events.
> 
> Dan found this when doing a static check.
> 
> This patch is to remove that check, and also to merge
> two checks into one 'if statement'.
> 
> Fixes: fb23403536ea ("sctp: remove the useless check in sctp_renege_events")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---
>  net/sctp/stream_interleave.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/net/sctp/stream_interleave.c b/net/sctp/stream_interleave.c
> index 65ac03b..d3764c1 100644
> --- a/net/sctp/stream_interleave.c
> +++ b/net/sctp/stream_interleave.c
> @@ -968,9 +968,8 @@ static void sctp_renege_events(struct sctp_ulpq *ulpq, struct sctp_chunk *chunk,
>  						       needed);
>  	}
>  
> -	if (chunk && freed >= needed)
> -		if (sctp_ulpevent_idata(ulpq, chunk, gfp) <= 0)
> -			sctp_intl_start_pd(ulpq, gfp);
> +	if (freed >= needed && sctp_ulpevent_idata(ulpq, chunk, gfp) <= 0)
> +		sctp_intl_start_pd(ulpq, gfp);
>  
>  	sk_mem_reclaim(asoc->base.sk);
>  }
> -- 
> 2.1.0
> 
> 
Acked-by: Neil Horman <nhorman@...driver.com>