netdev - Re: [net-next PATCH v1 3/3] net: stmmac: dwmac-meson8b: make the clock configurations private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1518885684.2883.111.camel@baylibre.com>
Date:   Sat, 17 Feb 2018 17:41:24 +0100
From:   Jerome Brunet <jbrunet@...libre.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-amlogic@...ts.infradead.org, netdev@...r.kernel.org
Cc:     khilman@...libre.com, carlo@...one.org, narmstrong@...libre.com
Subject: Re: [net-next PATCH v1 3/3] net: stmmac: dwmac-meson8b: make the
 clock configurations private

On Sat, 2018-02-17 at 15:08 +0100, Martin Blumenstingl wrote:
> The common clock framework needs access to the "clock configuration"
> structs during runtime.
> However, only the common clock framework should access these. Ensure
> this by moving the configuration structs out of struct meson8b_dwmac,
> so only meson8b_init_rgmii_tx_clk() and the common clock framework know
> about these configurations.
> 
> Suggested-by: Jerome Brunet <jbrunet@...libre.com>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

Acked-by: Jerome Brunet <jbrunet@...libre.com>

> ---
>  .../net/ethernet/stmicro/stmmac/dwmac-meson8b.c    | 45 ++++++++++++----------
>  1 file changed, 24 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
> index 0dfce35c5583..2d5d4aea3bcb 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
> @@ -49,19 +49,17 @@
>  
>  struct meson8b_dwmac {
>         struct device           *dev;
> -
>         void __iomem            *regs;
> -
>         phy_interface_t         phy_mode;
> +       struct clk              *rgmii_tx_clk;
> +       u32                     tx_delay_ns;
> +};
>  
> +struct meson8b_dwmac_clk_configs {

Not too sure we needed a struct for this, but it does work and does not matter
much

>         struct clk_mux          m250_mux;
>         struct clk_divider      m250_div;
>         struct clk_fixed_factor fixed_div2;
>         struct clk_gate         rgmii_tx_en;
> -
> -       struct clk              *rgmii_tx_clk;
> -
> -       u32                     tx_delay_ns;
>  };