netdev - RE: [PATCH net-next] dpaa_eth: fix pause capability advertisement logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM5PR04MB3267BAE1349183D6474E5A84ECC80@AM5PR04MB3267.eurprd04.prod.outlook.com>
Date:   Mon, 19 Feb 2018 16:00:18 +0000
From:   Madalin-cristian Bucur <madalin.bucur@....com>
To:     Jake Moroni <mail@...emoroni.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] dpaa_eth: fix pause capability advertisement
 logic

> -----Original Message-----
> From: Jake Moroni [mailto:mail@...emoroni.com]
> Sent: Sunday, February 18, 2018 10:26 PM
> To: Madalin-cristian Bucur <madalin.bucur@....com>
> Cc: netdev@...r.kernel.org; Jake Moroni <mail@...emoroni.com>
> Subject: [PATCH net-next] dpaa_eth: fix pause capability advertisement
> logic
> 
> The ADVERTISED_Asym_Pause bit was being improperly set when both
> rx and tx pause were enabled. When rx and tx are both enabled, only
> the ADVERTISED_Pause bit is supposed to be set.
> 
> Signed-off-by: Jake Moroni <mail@...emoroni.com>
> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
> index faea674..85306d1 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
> @@ -211,7 +211,7 @@ static int dpaa_set_pauseparam(struct net_device
> *net_dev,
>  	if (epause->rx_pause)
>  		newadv = ADVERTISED_Pause | ADVERTISED_Asym_Pause;
>  	if (epause->tx_pause)
> -		newadv |= ADVERTISED_Asym_Pause;
> +		newadv ^= ADVERTISED_Asym_Pause;
> 
>  	oldadv = phydev->advertising &
>  			(ADVERTISED_Pause | ADVERTISED_Asym_Pause);
> --
> 2.7.4

Acked-by: Madalin Bucur <madalin.bucur@....com>