netdev - Re: [patch net] mlxsw: spectrum_router: Do not unconditionally clear route offload indication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Feb 2018 11:21:45 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, alexpe@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [patch net] mlxsw: spectrum_router: Do not unconditionally
 clear route offload indication

From: Jiri Pirko <jiri@...nulli.us>
Date: Sat, 17 Feb 2018 00:30:44 +0100

> From: Ido Schimmel <idosch@...lanox.com>
> 
> When mlxsw replaces (or deletes) a route it removes the offload
> indication from the replaced route. This is problematic for IPv4 routes,
> as the offload indication is stored in the fib_info which is usually
> shared between multiple routes.
> 
> Instead of unconditionally clearing the offload indication, only clear
> it if no other route is using the fib_info.
> 
> Fixes: 3984d1a89fe7 ("mlxsw: spectrum_router: Provide offload indication using nexthop flags")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reported-by: Alexander Petrovskiy <alexpe@...lanox.com>
> Tested-by: Alexander Petrovskiy <alexpe@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> ---
> Dave, please, push to stable. Thanks!

Applied and queued up for -stable, thanks Jiri!