netdev - Re: [PATCH nf] netfilter: IDLETIMER: be syzkaller friendly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180219172716.vf4chjy5rgoyvhwm@salvia>
Date:   Mon, 19 Feb 2018 18:27:16 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Florian Westphal <fw@...len.de>, netfilter-devel@...r.kernel.org,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH nf] netfilter: IDLETIMER: be syzkaller friendly

On Fri, Feb 16, 2018 at 07:36:28PM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> We had one report from syzkaller [1]
> 
> First issue is that INIT_WORK() should be done before mod_timer()
> or we risk timer being fired too soon, even with a 1 second timer.
> 
> Second issue is that we need to reject too big info->timeout
> to avoid overflows in msecs_to_jiffies(info->timeout * 1000), or
> risk looping, if result after overflow is 0.

Applied, thanks!