netdev - Re: [PATCH net] tg3: APE heartbeat changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180219.141712.271423476108125356.davem@davemloft.net>
Date:   Mon, 19 Feb 2018 14:17:12 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     satish.baddipadige@...adcom.com
Cc:     netdev@...r.kernel.org, michael.chan@...adcom.com,
        prashant@...adcom.com, siva.kallam@...adcom.com,
        prashant.sreedharan@...adcom.com
Subject: Re: [PATCH net] tg3: APE heartbeat changes

From: Satish Baddipadige <satish.baddipadige@...adcom.com>
Date: Mon, 19 Feb 2018 12:27:04 +0530

> From: Prashant Sreedharan <prashant.sreedharan@...adcom.com>
> 
> In ungraceful host shutdown or driver crash case BMC connectivity is
> lost. APE firmware is missing the driver state in this
> case to keep the BMC connectivity alive.
> This patch has below change to address this issue.
> 
> Heartbeat mechanism with APE firmware. This heartbeat mechanism
> is needed to notify the APE firmware about driver state.
> 
> This patch also has the change in wait time for APE event from
> 1ms to 20ms as there can be some delay in getting response.
> 
> v2: Drop inline keyword as per David suggestion.
> 
> Signed-off-by: Prashant Sreedharan <prashant.sreedharan@...adcom.com>
> Signed-off-by: Satish Baddipadige <satish.baddipadige@...adcom.com>
> Signed-off-by: Siva Reddy Kallam <siva.kallam@...adcom.com>
> Acked-by: Michael Chan <michael.chan@...adcom.com>

Looks good, applied, thank you.