netdev - Re: [PATCH net] tg3: APE heartbeat changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 19 Feb 2018 12:12:19 +0530
From:   Satish Baddipadige <satish.baddipadige@...adcom.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Michael Chan <michael.chan@...adcom.com>,
        Prashant Sreedharan <prashant@...adcom.com>,
        "Siva Reddy (Siva) Kallam" <siva.kallam@...adcom.com>,
        Prashant Sreedharan <prashant.sreedharan@...adcom.com>
Subject: Re: [PATCH net] tg3: APE heartbeat changes

On Sat, Feb 17, 2018 at 2:56 AM, David Miller <davem@...emloft.net> wrote:
>
> From: Satish Baddipadige <satish.baddipadige@...adcom.com>
> Date: Fri, 16 Feb 2018 10:01:29 +0530
>
> > @@ -990,6 +984,18 @@ static void tg3_ape_driver_state_change(struct tg3 *tp, int kind)
> >       tg3_ape_send_event(tp, event);
> >  }
> >
> > +static inline void tg3_send_ape_heartbeat(struct tg3 *tp,
>
> Inline functions are not appropriate in foo.c files, please drop the
> inline keyword and let the compiler device.

Thanks David. Will send a v2 patch with inline dropped.

Thanks,
Satish