netdev - Re: [PATCH iproute2-next] ip link: add support to display extended tun attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98d79dd9-9e22-43aa-0811-913a77e5fd05@gmail.com>
Date:   Mon, 19 Feb 2018 21:09:30 -0700
From:   David Ahern <dsahern@...il.com>
To:     Serhey Popovych <serhe.popovych@...il.com>,
        Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org
Cc:     sbrivio@...hat.com
Subject: Re: [PATCH iproute2-next] ip link: add support to display extended
 tun attributes

On 2/19/18 3:19 PM, Serhey Popovych wrote:
> I get following checkpatch.pl warnings:
> 
> WARNING: Missing a blank line after declarations
> #73: FILE: ip/iptuntap.c:497:
> +               __u8 mq = rta_getattr_u8(tb[IFLA_TUN_MULTI_QUEUE]);
> +               if (!mq)
> 
> WARNING: Missing a blank line after declarations
> #80: FILE: ip/iptuntap.c:504:
> +               __u32 numq = rta_getattr_u32(tb[IFLA_TUN_NUM_QUEUES]);
> +               fprintf(f, "numqueues %u ", numq);
> 
> WARNING: Missing a blank line after declarations
> #85: FILE: ip/iptuntap.c:509:
> +               __u32 numq =
> rta_getattr_u32(tb[IFLA_TUN_NUM_DISABLED_QUEUES]);
> +               fprintf(f, "numdisabled %u ", numq);
> 
> maybe they should be fixed before accepting?

yes. Please fix; headers have been updated to 4.16.0-rc2+, f5c0c6f4299f,
so you can drop those from v2