netdev - Re: [PATCH net] xfrm: do not call rcu_read_unlock when afinfo is NULL in xfrm_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180220063805.mfx7zgy32xgs263c@gauss3.secunet.de>
Date:   Tue, 20 Feb 2018 07:38:05 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Xin Long <lucien.xin@...il.com>
CC:     network dev <netdev@...r.kernel.org>, <davem@...emloft.net>,
        "Florian Westphal" <fw@...len.de>
Subject: Re: [PATCH net] xfrm: do not call rcu_read_unlock when afinfo is
 NULL in xfrm_get_tos

On Sat, Feb 17, 2018 at 03:16:22PM +0800, Xin Long wrote:
> When xfrm_policy_get_afinfo returns NULL, it will not hold rcu
> read lock. In this case, rcu_read_unlock should not be called
> in xfrm_get_tos, just like other places where it's calling
> xfrm_policy_get_afinfo.
> 
> Fixes: f5e2bb4f5b22 ("xfrm: policy: xfrm_get_tos cannot fail")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied, thanks Xin!