netdev - Re: [PATCH v1 1/1] drivers: isdn: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Feb 2018 08:47:10 -0500
From:   Joe Moriarty <joe.moriarty@...cle.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v1 1/1] drivers: isdn: NULL pointer dereference
 [null-pointer-deref] (CWE 476) problem

On 2/16/2018 4:11 PM, David Miller wrote:
> From: Joe Moriarty <joe.moriarty@...cle.com>
> Date: Thu, 15 Feb 2018 15:27:00 -0500
> 
>> The Parfait (version 2.1.0) static code analysis tool found the
>> following NULL pointer dereference problem.
>>
>> - drivers/isdn/mISDN/core.c
>> function channelmap_show() does not check the returned mdev
>> variable from dev_to_mISDN() for NULL.  Added the check for
>> NULL, which results in a value of 0 being returned.
>>
>> Signed-off-by: Joe Moriarty <joe.moriarty@...cle.com>
>> Reviewed-by: Jonathan Helman <jonathan.helman@...cle.com>
> 
> Since the lifetime for the sysfs files for these devices is strictly
> smaller than the lifetime of the 'dev' object and it's driver data,
> it is not possible for mdev to be NULL in this situation.
> 
> I understand what the static checker is trying to do, but within
> context this lack of a NULL check is legitimate.
> 
> I'm not applying this, sorry.
> 
Thanks for the review David and there is no reason to be sorry.  I'll 
will mark this as a false positive result from our static checker.