netdev - Re: ixgbe tuning reset when XDP is setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Feb 2018 15:01:33 -0500
From:   Peter Manev <petermanev@...il.com>
To:     Alexander Duyck <alexander.duyck@...il.com>
Cc:     John Fastabend <john.fastabend@...il.com>,
        David Miller <davem@...emloft.net>,
        Eric Leblond <eric@...it.org>, Netdev <netdev@...r.kernel.org>,
        xdp-newbies@...r.kernel.org,
        Emil Tantilov <emil.s.tantilov@...el.com>
Subject: Re: ixgbe tuning reset when XDP is setup

>>
>> Hi,
>>
>> We were wondering if there is any follow up/potential solution for that?
>> If there is something we could help out testing with regards to that
>> - please let us know.
>>
>> Thank you
>>
>> --
>> Regards,
>> Peter Manev
>
> We don't have a solution available for this yet. Basically what it
> comes down to is that we have to change the driver code so that if
> assumes it is going to need to alloc Tx rings for XDP always, and then
> if it can't we have to disable the XDP feature. The current logic is
> to advertise the XDP feature, and then allocate the rings when XDP is
> actually used, and if that fails we fail to load the XDP program.
>
> Unfortunately I don't have an ETA for when we can get to that. It may
> be a while, however patches are always welcome.
>
> Thanks.
>
> - Alex

It seems the issue is not present on 4.15.2 (while it is in 4.13.10
for example) using the ixgbe available in tree
(/lib/modules/4.15.2-amd64/kernel/drivers/net/ethernet/intel/ixgbe)

Not sure what triggered the fix -  thought here would be a good place
to ask for some pointers.

Thank you

-- 
Regards,
Peter Manev