netdev - Re: [PATCH v2] sched: report if filter is too large to dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6b76ea2-47a2-967c-5e5d-db1148167295@rkapl.cz>
Date:   Wed, 21 Feb 2018 09:49:31 +0100
From:   Roman Kapl <code@...pl.cz>
To:     Phil Sutter <phil@....cc>, netdev@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...nulli.us>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Benc <jbenc@...hat.com>
Subject: Re: [PATCH v2] sched: report if filter is too large to dump

On 02/21/2018 09:42 AM, Phil Sutter wrote:
> Hi Roman,
>
> On Wed, Feb 21, 2018 at 09:38:52AM +0100, Roman Kapl wrote:
>> On 02/21/2018 08:45 AM, Phil Sutter wrote:
>>> On Mon, Feb 19, 2018 at 09:32:51PM +0100, Roman Kapl wrote:
>>>> Note: The error case can happen pretty easily if you create a filter
>>>> with 32 actions and have 4kb pages. Also recent versions of iproute try
>>>> to be clever with their buffer allocation size, which in turn leads to
>>> I'm curious, what does it lead to? :)
>>>
>>> Thanks, Phil
>> tc will dump all filters up to the big one, then it will stop silently.
>> So it will seem as if you have less filters.
>>
>> The new behavior is the same, but tc will at leas print the EMSGSIZE
>> error. It does not handle it in any other way.
> I got that, yes. Though your commit message stops mid-sentence and I
> wondered what the dynamic buffer allocation "in turn leads to".
>
> Thanks, Phil

Aaah... It leads to "smaller SKBs in kernel". I've lost that line in v2.

Should I send a v3 or something, David?

Sorry, Roman Kapl