netdev - Re: [PATCH iproute2-next v2] ip: link_gre6.c: Support IP6_TNL_F_ALLOW_LOCAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wihd10ysi4h.fsf@dev-r-vrt-156.mtr.labs.mlnx>
Date:   Wed, 21 Feb 2018 13:21:34 +0200
From:   Petr Machata <petrm@...lanox.com>
To:     Serhey Popovych <serhe.popovych@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next v2] ip: link_gre6.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag

Serhey Popovych <serhe.popovych@...il.com> writes:

> Petr Machata wrote:
>> For IP-in-IP tunnels, one can specify the [no]allow-localremote command
>> when configuring a device. Under the hood, this flips the
>> IP6_TNL_F_ALLOW_LOCAL_REMOTE flag on the netdevice. However, ip6gretap
>> and ip6erspan devices, where the flag is also relevant, are not IP-in-IP
>> tunnels, and thus there's no way to configure the flag on these
>> netdevices. Therefore introduce the command to link_gre6 as well.
>> 
>> The original support was introduced in commit
>> 21440d19d957 ("ip: link_ip6tnl.c/ip6tunnel.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag")
>
> This would produce following checkpatch.pl error:
>
> ----------------------------------------------------------------------------------
> Commit b7a2f4a74cd0 ("ip: link_gre6.c: Support
> IP6_TNL_F_ALLOW_LOCAL_REMOTE flag")
> ----------------------------------------------------------------------------------
> WARNING: Possible unwrapped commit description (prefer a maximum 75
> chars per line)
> #14:
> 21440d19d957 ("ip: link_ip6tnl.c/ip6tunnel.c: Support
> IP6_TNL_F_ALLOW_LOCAL_REMOTE flag")
>
> ERROR: Please use git commit description style 'commit <12+ chars of
> sha1> ("<title line>")' - ie: 'commit 21440d19d957 ("ip:
> link_ip6tnl.c/ip6tunnel.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOT'
> #14:
> 21440d19d957 ("ip: link_ip6tnl.c/ip6tunnel.c: Support
> IP6_TNL_F_ALLOW_LOCAL_REMOTE flag")
>
> You probably should address it. In general change looks good to me.

v3 sent. The "unwrapped commit description" warning stays on the commit
reference line, but I don't see a way to shorten it without triggering
the above error again.

Thanks,
Petr