| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <201802222251.VL8a1ZdD%fengguang.wu@intel.com>
Date: Thu, 22 Feb 2018 22:48:10 +0800
From: kbuild test robot <lkp@...el.com>
To: Yonghong Song <yhs@...com>
Cc: kbuild-all@...org, ast@...com, daniel@...earbox.net,
edumazet@...gle.com, netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH bpf] bpf: fix rcu lockdep warning for lpm_trie map_free
callback
Hi Yonghong,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf/master]
url: https://github.com/0day-ci/linux/commits/Yonghong-Song/bpf-fix-rcu-lockdep-warning-for-lpm_trie-map_free-callback/20180222-202658
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
include/linux/init.h:134:6: sparse: attribute 'indirect_branch': unknown attribute
include/linux/init.h:135:5: sparse: attribute 'indirect_branch': unknown attribute
include/linux/init.h:268:6: sparse: attribute 'indirect_branch': unknown attribute
include/linux/init.h:269:6: sparse: attribute 'indirect_branch': unknown attribute
include/linux/printk.h:200:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/mem_encrypt.h:32:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/mem_encrypt.h:34:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/mem_encrypt.h:37:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/mem_encrypt.h:38:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/mem_encrypt.h:40:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/mem_encrypt.h:42:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/mem_encrypt.h:43:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/mem_encrypt.h:45:5: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/mem_encrypt.h:46:5: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/mem_encrypt.h:49:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/qspinlock.h:53:32: sparse: attribute 'indirect_branch': unknown attribute
include/linux/workqueue.h:646:5: sparse: attribute 'indirect_branch': unknown attribute
include/linux/workqueue.h:647:5: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/numa.h:34:12: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/numa.h:35:13: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/numa.h:62:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/vmalloc.h:64:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/vmalloc.h:173:8: sparse: attribute 'indirect_branch': unknown attribute
include/linux/vmalloc.h:174:8: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/fixmap.h:174:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/fixmap.h:176:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/fixmap.h:178:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/fixmap.h:180:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/apic.h:254:13: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/apic.h:430:13: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/io_apic.h:184:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/smp.h:113:6: sparse: attribute 'indirect_branch': unknown attribute
include/linux/smp.h:125:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/smp.h:126:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/percpu.h:110:33: sparse: attribute 'indirect_branch': unknown attribute
include/linux/percpu.h:112:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/percpu.h:114:12: sparse: attribute 'indirect_branch': unknown attribute
include/linux/percpu.h:118:12: sparse: attribute 'indirect_branch': unknown attribute
include/linux/percpu.h:126:12: sparse: attribute 'indirect_branch': unknown attribute
include/linux/memory_hotplug.h:221:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/mmzone.h:1292:15: sparse: attribute 'indirect_branch': unknown attribute
include/linux/kmemleak.h:29:33: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/kasan.h:29:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/kasan.h:30:6: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/pgtable.h:28:5: sparse: attribute 'indirect_branch': unknown attribute
include/linux/slab.h:135:6: sparse: attribute 'indirect_branch': unknown attribute
include/linux/slab.h:716:6: sparse: attribute 'indirect_branch': unknown attribute
include/linux/wait_bit.h:41:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/fs.h:63:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/fs.h:64:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/fs.h:65:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/fs.h:66:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/fs.h:2421:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/fs.h:2422:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/fs.h:3329:5: sparse: attribute 'indirect_branch': unknown attribute
include/linux/hrtimer.h:497:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/mm.h:1753:6: sparse: attribute 'indirect_branch': unknown attribute
include/linux/mm.h:1941:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/mm.h:2083:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/mm.h:2671:6: sparse: attribute 'indirect_branch': unknown attribute
include/linux/swiotlb.h:39:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/swiotlb.h:124:13: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/swiotlb.h:9:12: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/swiotlb.h:10:12: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/swiotlb.h:11:13: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/swiotlb.h:12:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/dma-contiguous.h:85:5: sparse: attribute 'indirect_branch': unknown attribute
include/linux/cred.h:167:13: sparse: attribute 'indirect_branch': unknown attribute
include/linux/nsproxy.h:74:5: sparse: attribute 'indirect_branch': unknown attribute
include/linux/io.h:47:6: sparse: attribute 'indirect_branch': unknown attribute
include/linux/netdevice.h:302:5: sparse: attribute 'indirect_branch': unknown attribute
include/linux/netdevice.h:4056:5: sparse: attribute 'indirect_branch': unknown attribute
arch/x86/include/asm/vdso.h:44:13: sparse: attribute 'indirect_branch': unknown attribute
>> kernel/bpf/lpm_trie.c:569:22: sparse: incorrect type in assignment (different address spaces) @@ expected struct lpm_trie_node @@ got struct lpm_trie_nstruct lpm_trie_node @@
kernel/bpf/lpm_trie.c:569:22: expected struct lpm_trie_node
kernel/bpf/lpm_trie.c:569:22: got struct lpm_trie_node
kernel/bpf/lpm_trie.c:577:38: sparse: incorrect type in assignment (different address spaces) @@ expected struct lpm_trie_node @@ got struct lpm_trie_nstruct lpm_trie_node @@
kernel/bpf/lpm_trie.c:577:38: expected struct lpm_trie_node
kernel/bpf/lpm_trie.c:577:38: got struct lpm_trie_node
kernel/bpf/lpm_trie.c:582:38: sparse: incorrect type in assignment (different address spaces) @@ expected struct lpm_trie_node @@ got struct lpm_trie_nstruct lpm_trie_node @@
kernel/bpf/lpm_trie.c:582:38: expected struct lpm_trie_node
kernel/bpf/lpm_trie.c:582:38: got struct lpm_trie_node
vim +569 kernel/bpf/lpm_trie.c
b95a5c4db Daniel Mack 2017-01-21 551
b95a5c4db Daniel Mack 2017-01-21 552 static void trie_free(struct bpf_map *map)
b95a5c4db Daniel Mack 2017-01-21 553 {
b95a5c4db Daniel Mack 2017-01-21 554 struct lpm_trie *trie = container_of(map, struct lpm_trie, map);
ca073514f Yonghong Song 2018-02-21 555 struct lpm_trie_node **slot;
b95a5c4db Daniel Mack 2017-01-21 556 struct lpm_trie_node *node;
b95a5c4db Daniel Mack 2017-01-21 557
9a3efb6b6 Yonghong Song 2018-02-13 558 /* Wait for outstanding programs to complete
9a3efb6b6 Yonghong Song 2018-02-13 559 * update/lookup/delete/get_next_key and free the trie.
9a3efb6b6 Yonghong Song 2018-02-13 560 */
9a3efb6b6 Yonghong Song 2018-02-13 561 synchronize_rcu();
b95a5c4db Daniel Mack 2017-01-21 562
b95a5c4db Daniel Mack 2017-01-21 563 /* Always start at the root and walk down to a node that has no
b95a5c4db Daniel Mack 2017-01-21 564 * children. Then free that node, nullify its reference in the parent
b95a5c4db Daniel Mack 2017-01-21 565 * and start over.
b95a5c4db Daniel Mack 2017-01-21 566 */
b95a5c4db Daniel Mack 2017-01-21 567
b95a5c4db Daniel Mack 2017-01-21 568 for (;;) {
b95a5c4db Daniel Mack 2017-01-21 @569 slot = &trie->root;
b95a5c4db Daniel Mack 2017-01-21 570
b95a5c4db Daniel Mack 2017-01-21 571 for (;;) {
ca073514f Yonghong Song 2018-02-21 572 node = *slot;
b95a5c4db Daniel Mack 2017-01-21 573 if (!node)
9a3efb6b6 Yonghong Song 2018-02-13 574 goto out;
b95a5c4db Daniel Mack 2017-01-21 575
ca073514f Yonghong Song 2018-02-21 576 if (node->child[0]) {
b95a5c4db Daniel Mack 2017-01-21 577 slot = &node->child[0];
b95a5c4db Daniel Mack 2017-01-21 578 continue;
b95a5c4db Daniel Mack 2017-01-21 579 }
b95a5c4db Daniel Mack 2017-01-21 580
ca073514f Yonghong Song 2018-02-21 581 if (node->child[1]) {
b95a5c4db Daniel Mack 2017-01-21 582 slot = &node->child[1];
b95a5c4db Daniel Mack 2017-01-21 583 continue;
b95a5c4db Daniel Mack 2017-01-21 584 }
b95a5c4db Daniel Mack 2017-01-21 585
b95a5c4db Daniel Mack 2017-01-21 586 kfree(node);
ca073514f Yonghong Song 2018-02-21 587 *slot = NULL;
b95a5c4db Daniel Mack 2017-01-21 588 break;
b95a5c4db Daniel Mack 2017-01-21 589 }
b95a5c4db Daniel Mack 2017-01-21 590 }
b95a5c4db Daniel Mack 2017-01-21 591
9a3efb6b6 Yonghong Song 2018-02-13 592 out:
9a3efb6b6 Yonghong Song 2018-02-13 593 kfree(trie);
b95a5c4db Daniel Mack 2017-01-21 594 }
b95a5c4db Daniel Mack 2017-01-21 595
:::::: The code at line 569 was first introduced by commit
:::::: b95a5c4db09bc7c253636cb84dc9b12c577fd5a0 bpf: add a longest prefix match trie map implementation
:::::: TO: Daniel Mack <daniel@...que.org>
:::::: CC: David S. Miller <davem@...emloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Powered by blists - more mailing lists