netdev - Re: [PATCH net] smsc75xx: fix smsc75xx_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180222.140526.540412089618526073.davem@davemloft.net>
Date:   Thu, 22 Feb 2018 14:05:26 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, steve.glendinning@...well.net
Subject: Re: [PATCH net] smsc75xx: fix smsc75xx_set_features()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 20 Feb 2018 21:42:26 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> If an attempt is made to disable RX checksums, USB adapter is changed
> but netdev->features is not, because smsc75xx_set_features() returns a
> non zero value.
> 
> This throws errors from netdev_rx_csum_fault() :
> <devname>: hw csum failure
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Steve Glendinning <steve.glendinning@...well.net>

Applied, thanks Eric.