netdev - Re: [PATCH net-next] rds: rds_msg_zcopy should return error of null rm->data.op_mmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-+hYbA+z=hOmcQxZJedCR1C9O++-pxuG0wwJAeEJZQQcA@mail.gmail.com>
Date:   Thu, 22 Feb 2018 17:44:08 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Sowmini Varadhan <sowmini.varadhan@...cle.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Santosh Shilimkar <santosh.shilimkar@...cle.com>
Subject: Re: [PATCH net-next] rds: rds_msg_zcopy should return error of null rm->data.op_mmp_znotifier

On Thu, Feb 22, 2018 at 4:40 PM, Sowmini Varadhan
<sowmini.varadhan@...cle.com> wrote:
> if either or both of MSG_ZEROCOPY and SOCK_ZEROCOPY have not been
> specified, the rm->data.op_mmp_znotifier allocation will be skipped.
> In this case, it is invalid ot pass down a cmsghdr with
> RDS_CMSG_ZCOPY_COOKIE, so return EINVAL from rds_msg_zcopy for this
> case.
>
> Reported-by: syzbot+f893ae7bb2f6456dfbc3@...kaller.appspotmail.com
> Fixes: 0cebaccef3ac ("rds: zerocopy Tx support.")
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>