[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20180223.135052.1020621904894938943.davem@davemloft.net>
Date: Fri, 23 Feb 2018 13:50:52 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: batuhanosmantaskaya@...il.com
Cc: netdev@...r.kernel.org, batuhan@...il.com
Subject: Re: [PATCH 1/1] Linux Traffic Control (tc) unit testing suite's
code quality improved, String formattings updated. According to python
documentation "The built-in string class provides the ability to do
complex variable substitutions and value formatting via the format()
method described in PEP 3101. " but the project was using old type
formattings and new type string formattings together. This patch's purpose
is converting other old-type-string formattings to new type string
formattings in Linux Traffic Control Unit Testing Suit.
From: BTaskaya <batuhanosmantaskaya@...il.com>
Date: Fri, 23 Feb 2018 21:48:30 +0300
> Signed-off-by: Batuhan Osman Taskaya <batuhan@...il.com>
Sorry, this still is not submitted properly.
You Subject line is enormous. It should contain a short,
concise, title for the change. Including subsystem prefixes,
followed by a colon character, and a space, then the
title text.
The rest belongs in the commit message proper, and thus the
message body.
I asked you quite politely to look at how other people submit
patches properly on this mailing list, so that you could observe,
learn, and see how it is supposed to look.
If you had done so, we wouldn't have to go back and forth like
this.
So please take my polite suggestion seriously.
Thank you.
Powered by blists - more mailing lists