netdev - Re: [PATCH] net: fib_rules: Add new attribute to set protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180223.154733.1790130059786107888.davem@davemloft.net>
Date:   Fri, 23 Feb 2018 15:47:33 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sharpd@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com, idosch@...sch.org
Subject: Re: [PATCH] net: fib_rules: Add new attribute to set protocol

From: Donald Sharp <sharpd@...ulusnetworks.com>
Date: Fri, 23 Feb 2018 14:01:52 -0500

> For ages iproute2 has used `struct rtmsg` as the ancillary header for
> FIB rules and in the process set the protocol value to RTPROT_BOOT.
> Until ca56209a66 ("net: Allow a rule to track originating protocol")
> the kernel rules code ignored the protocol value sent from userspace
> and always returned 0 in notifications. To avoid incompatibility with
> existing iproute2, send the protocol as a new attribute.
> 
> Fixes: cac56209a66 ("net: Allow a rule to track originating protocol")
> Signed-off-by: Donald Sharp <sharpd@...ulusnetworks.com>

Applied, thanks Donald.