netdev - Re: [PATCH net-next 6/7] mlxsw: spectrum_router: Add support for ipv6 hash policy update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201802240103.ProaL017%fengguang.wu@intel.com>
Date:   Sat, 24 Feb 2018 01:09:47 +0800
From:   kbuild test robot <lkp@...el.com>
To:     David Ahern <dsahern@...il.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, idosch@...sch.org,
        tom@...bertland.com, davem@...emloft.net,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next 6/7] mlxsw: spectrum_router: Add support for
 ipv6 hash policy update

Hi David,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/David-Ahern/net-ipv6-Add-support-for-path-selection-using-hash-of-5-tuple/20180222-222437
config: x86_64-randconfig-u0-02240002 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c: In function 'mlxsw_sp_mp6_hash_init':
>> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:7027:26: error: 'struct net' has no member named 'ipv6'
     bool only_l3 = !init_net.ipv6.sysctl.multipath_hash_policy;
                             ^

vim +7027 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

  7024	
  7025	static void mlxsw_sp_mp6_hash_init(char *recr2_pl)
  7026	{
> 7027		bool only_l3 = !init_net.ipv6.sysctl.multipath_hash_policy;
  7028	
  7029		mlxsw_sp_mp_hash_header_set(recr2_pl,
  7030					    MLXSW_REG_RECR2_IPV6_EN_NOT_TCP_NOT_UDP);
  7031		mlxsw_sp_mp_hash_header_set(recr2_pl, MLXSW_REG_RECR2_IPV6_EN_TCP_UDP);
  7032		mlxsw_reg_recr2_ipv6_sip_enable(recr2_pl);
  7033		mlxsw_reg_recr2_ipv6_dip_enable(recr2_pl);
  7034		mlxsw_sp_mp_hash_field_set(recr2_pl, MLXSW_REG_RECR2_IPV6_NEXT_HEADER);
  7035		if (only_l3) {
  7036			mlxsw_sp_mp_hash_field_set(recr2_pl, MLXSW_REG_RECR2_IPV6_FLOW_LABEL);
  7037		} else {
  7038			mlxsw_sp_mp_hash_header_set(recr2_pl, MLXSW_REG_RECR2_TCP_UDP_EN_IPV6);
  7039			mlxsw_sp_mp_hash_field_set(recr2_pl, MLXSW_REG_RECR2_TCP_UDP_SPORT);
  7040			mlxsw_sp_mp_hash_field_set(recr2_pl, MLXSW_REG_RECR2_TCP_UDP_DPORT);
  7041		}
  7042	}
  7043	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29556 bytes)