[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20180223.122700.2270857062946139923.davem@davemloft.net>
Date: Fri, 23 Feb 2018 12:27:00 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: aspencer@...cex.com
Cc: netdev@...r.kernel.org, claudiu.manoil@...escale.com
Subject: Re: [PATCH net] gianfar: simplify FCS handling and fix memory leak
From: Andy Spencer <aspencer@...cex.com>
Date: Thu, 22 Feb 2018 11:05:33 -0800
> Previously, buffer descriptors containing only the frame check sequence
> (FCS) were skipped and not added to the skb. However, the page reference
> count was still incremented, leading to a memory leak.
>
> Fixing this inside gfar_add_rx_frag() is difficult due to reserved
> memory handling and page reuse. Instead, move the FCS handling to
> gfar_process_frame() and trim off the FCS before passing the skb up the
> networking stack.
>
> Signed-off-by: Andy Spencer <aspencer@...cex.com>
> Signed-off-by: Jim Gruen <jgruen@...cex.com>
Applied, thank you.
Powered by blists - more mailing lists