netdev - Re: [PATCH net-next] cxgb4vf: Forcefully link up virtual interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180223.124529.33988764914477795.davem@davemloft.net>
Date:   Fri, 23 Feb 2018 12:45:29 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ganeshgr@...lsio.com
Cc:     netdev@...r.kernel.org, leedom@...lsio.com, nirranjan@...lsio.com,
        indranil@...lsio.com, venkatesh@...lsio.com, arjun@...lsio.com
Subject: Re: [PATCH net-next] cxgb4vf: Forcefully link up virtual interfaces

From: Ganesh Goudar <ganeshgr@...lsio.com>
Date: Fri, 23 Feb 2018 20:36:53 +0530

> @@ -92,6 +92,18 @@ module_param(msi, int, 0644);
>  MODULE_PARM_DESC(msi, "whether to use MSI-X or MSI");
>  
>  /*
> + * Logic controls.
> + * ===============
> + */
> +
> +/* The Virtual Interfaces are connected to an internal switch on the chip
> + * which allows VIs attached to the same port to talk to each other even when
> + * the port link is down.  As a result, we generally want to always report a
> + * VI's link as being "up".
> + */
> +#define force_link_up 1

Please don't do this, just perform the actions unconditionally.