netdev - Re: [PATCH net-next 0/5] fib_rules: support sport, dport and ip proto match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b0f3796-af8b-96af-690b-1c9f87bc35f1@cumulusnetworks.com>
Date:   Sun, 25 Feb 2018 20:20:35 -0700
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     nikolay@...ulusnetworks.com, idosch@...lanox.com
Subject: Re: [PATCH net-next 0/5] fib_rules: support sport, dport and ip proto
 match

On 2/24/18 10:44 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> This series extends fib rule match support to include sport, dport
> and ip proto match (to complete the 5-tuple match support).
> Common use-cases of Policy based routing in the data center require
> 5-tuple match. The last 2 patches in the series add a call to flow dissect
> in the fwd path if required by the installed fib rules (controlled by a flag).
> 
> v1:
>   - Fix errors reported by kbuild and feedback on RFC series
>   - extend port match uapi to accomodate port ranges

Would be good to have a test script under tools/testing/selftests/net
that covers expectations for good and bad cases. Can create one based on
tools/testing/selftests/net/fib-onlink-tests.sh