netdev - Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180226100638.789a770d@xeon-e3>
Date:   Mon, 26 Feb 2018 10:06:38 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Serhey Popovych <serhe.popovych@...il.com>
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments
 to iplink_parse()

On Thu, 22 Feb 2018 15:02:06 +0200
Serhey Popovych <serhe.popovych@...il.com> wrote:

> +struct iplink_parse_args {
> +	const char *dev;
> +	const char *name;
> +	const char *type;
> +
> +	/* This definitely must be the last one and initialized
> +	 * by the caller of iplink_parse() that will initialize rest.
> +	 */
> +	struct iplink_req *req;
> +};
> +

No control block please.
If you have too many arguments, then that means you need to do
some refactoring.