netdev - Re: [net] ixgbe: fix crash in build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180226.134749.1372103055616948220.davem@davemloft.net>
Date:   Mon, 26 Feb 2018 13:47:49 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     emil.s.tantilov@...el.com, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com,
        stable@...r.kernel.org
Subject: Re: [net] ixgbe: fix crash in build_skb Rx code path

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 23 Feb 2018 12:39:41 -0800

> From: Emil Tantilov <emil.s.tantilov@...el.com>
> 
> Add check for build_skb enabled ring in ixgbe_dma_sync_frag().
> In that case &skb_shinfo(skb)->frags[0] may not always be set which
> can lead to a crash. Instead we derive the page offset from skb->data.
> 
> Fixes: 42073d91a214
> ("ixgbe: Have the CPU take ownership of the buffers sooner")
> CC: stable <stable@...r.kernel.org>
> Reported-by: Ambarish Soman <asoman@...hat.com>
> Suggested-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Signed-off-by: Emil Tantilov <emil.s.tantilov@...el.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied, thanks Jeff.