netdev - Re: [PATCH net-next v2] r8169: improve interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Feb 2018 13:56:22 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, romieu@...zoreil.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] r8169: improve interrupt handling

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sat, 24 Feb 2018 16:53:23 +0100

> @@ -736,8 +736,7 @@ struct ring_info {
>  };
>  
>  enum features {
> -	RTL_FEATURE_MSI		= (1 << 0),
> -	RTL_FEATURE_GMII	= (1 << 1),
> +	RTL_FEATURE_GMII	= (1 << 0),
>  };
>  
>  struct rtl8169_counters {
 ...
> +	if (tp->mac_version <= RTL_GIGA_MAC_VER_06) {

Please, if you are going to keep the logic the same for the older
chips, just keep the RTL_FEATURE_MSI flag around instead of adding
new (and potentially regression causing) tests for this condition.

Thank you.