netdev - Re: [PATCH net] bridge: Fix VLAN reference count problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180226.151939.437417379111753394.davem@redhat.com>
Date:   Mon, 26 Feb 2018 15:19:39 -0500 (EST)
From:   David Miller <davem@...hat.com>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
        nikolay@...ulusnetworks.com, stephen@...workplumber.org,
        elena.reshetova@...el.com, mlxsw@...lanox.com
Subject: Re: [PATCH net] bridge: Fix VLAN reference count problem

From: Ido Schimmel <idosch@...lanox.com>
Date: Sun, 25 Feb 2018 21:59:06 +0200

> When a VLAN is added on a port, a reference is taken on the
> corresponding master VLAN entry. If it does not already exist, then it
> is created and a reference taken.
> 
> However, in the second case a reference is not really taken when
> CONFIG_REFCOUNT_FULL is enabled as refcount_inc() is replaced by
> refcount_inc_not_zero().
> 
> Fix this by using refcount_set() on a newly created master VLAN entry.
> 
> Fixes: 251277598596 ("net, bridge: convert net_bridge_vlan.refcnt from atomic_t to refcount_t")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Applied and queued up for -stable, thanks!