netdev - Re: [patch net] devlink: Compare to size_new in case of resource child validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180227.105336.161722008755188850.davem@davemloft.net>
Date:   Tue, 27 Feb 2018 10:53:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, arkadis@...lanox.com, mlxsw@...lanox.com
Subject: Re: [patch net] devlink: Compare to size_new in case of resource
 child validation

From: Jiri Pirko <jiri@...nulli.us>
Date: Mon, 26 Feb 2018 10:59:53 +0100

> From: Arkadi Sharshevsky <arkadis@...lanox.com>
> 
> The current implementation checks the combined size of the children with
> the 'size' of the parent. The correct behavior is to check the combined
> size vs the pending change and to compare vs the 'size_new'.
> 
> Fixes: d9f9b9a4d05f ("devlink: Add support for resource abstraction")
> Signed-off-by: Arkadi Sharshevsky <arkadis@...lanox.com>
> Tested-by: Yuval Mintz <yuvalm@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied, thank you.