netdev - Re: [PATCH bpf-next 1/2] bpf: extend stackmap to save binary_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E26961B7-377A-4E19-BB53-0B7F0A3AB452@fb.com>
Date:   Tue, 27 Feb 2018 17:07:24 +0000
From:   Song Liu <songliubraving@...com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "ast@...nel.org" <ast@...nel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        Kernel Team <Kernel-team@...com>,
        "hannes@...xchg.org" <hannes@...xchg.org>
Subject: Re: [PATCH bpf-next 1/2] bpf: extend stackmap to save
 binary_build_id+offset instead of address



> On Feb 27, 2018, at 8:42 AM, David Miller <davem@...emloft.net> wrote:
> 
> From: Song Liu <songliubraving@...com>
> Date: Mon, 26 Feb 2018 09:49:22 -0800
> 
>> diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c
>> index b0ecf43..e6a48ca 100644
>> --- a/kernel/bpf/stackmap.c
>> +++ b/kernel/bpf/stackmap.c
>> @@ -9,16 +9,18 @@
>> #include <linux/filter.h>
>> #include <linux/stacktrace.h>
>> #include <linux/perf_event.h>
>> +#include <uapi/linux/elf.h>
>> #include "percpu_freelist.h"
> 
> Hmmm, why do you explicitly need to include a uapi path?  linux/elf.h
> should resolve naturally without such an explicit uapi path.

Yeah, that's right. I will fix this in v2. 

Thanks,
Song