netdev - RE: [PATCH net-next 2/3] net: mvpp2: adjust gso stop wake thresholds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87f896cb9e774ee083227ddd2f1c88ea@IL-EXCH01.marvell.com>
Date:   Tue, 27 Feb 2018 17:48:44 +0000
From:   Yan Markman <ymarkman@...vell.com>
To:     Antoine Tenart <antoine.tenart@...tlin.com>,
        David Miller <davem@...emloft.net>
CC:     "mw@...ihalf.com" <mw@...ihalf.com>,
        Stefan Chulski <stefanc@...vell.com>,
        "thomas.petazzoni@...e-electrons.com" 
        <thomas.petazzoni@...e-electrons.com>,
        "gregory.clement@...e-electrons.com" 
        <gregory.clement@...e-electrons.com>,
        "miquel.raynal@...e-electrons.com" <miquel.raynal@...e-electrons.com>,
        "Nadav Haklai" <nadavh@...vell.com>,
        "maxime.chevallier@...tlin.com" <maxime.chevallier@...tlin.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 2/3] net: mvpp2: adjust gso stop wake thresholds

I will make this tomorrow.
Thanks for attention!
Best regards
Yan Markman
Tel. 05-44732819


-----Original Message-----
From: Antoine Tenart [mailto:antoine.tenart@...tlin.com] 
Sent: Tuesday, February 27, 2018 7:14 PM
To: David Miller <davem@...emloft.net>
Cc: antoine.tenart@...tlin.com; Yan Markman <ymarkman@...vell.com>; mw@...ihalf.com; Stefan Chulski <stefanc@...vell.com>; thomas.petazzoni@...e-electrons.com; gregory.clement@...e-electrons.com; miquel.raynal@...e-electrons.com; Nadav Haklai <nadavh@...vell.com>; maxime.chevallier@...tlin.com; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] net: mvpp2: adjust gso stop wake thresholds

Hi David,

On Tue, Feb 27, 2018 at 11:13:06AM -0500, David Miller wrote:
> From: Antoine Tenart <antoine.tenart@...tlin.com>
> > From: Yan Markman <ymarkman@...vell.com>
> > -#define MVPP2_MAX_TSO_SEGS		300
> > +#define MVPP2_MAX_TSO_SEGS		100
> >  #define MVPP2_MAX_SKB_DESCS		(MVPP2_MAX_TSO_SEGS * 2 + MAX_SKB_FRAGS)
> >  
> >  /* Dfault number of RXQs in use */
> > @@ -5810,7 +5810,7 @@ static int mvpp2_txq_init(struct mvpp2_port *port,
> >  		txq_pcpu->tso_headers = NULL;
> >  
> >  		txq_pcpu->stop_threshold = txq->size - MVPP2_MAX_SKB_DESCS;
> > -		txq_pcpu->wake_threshold = txq_pcpu->stop_threshold / 2;
> > +		txq_pcpu->wake_threshold = txq_pcpu->stop_threshold - 100;
> >  
> 
> This number 100 is a magic constant.  If it is related to 
> MVPP2_MAX_TSO_SEGS, please use that define.  Otherwise define a new 
> one which is descriptive.

I agree. I'll ask Yan about it and update if possible.

Thanks!
Antoine

--
Antoine Ténart, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com