netdev - Re: [PATCH 0/5 net-next] ibmvnic: Miscellaneous driver fixes and enhancements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180227.143137.2086154618936386109.davem@davemloft.net>
Date:   Tue, 27 Feb 2018 14:31:37 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tlfalcon@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, jallen@...ux.vnet.ibm.com,
        nfont@...ux.vnet.ibm.com
Subject: Re: [PATCH 0/5 net-next] ibmvnic: Miscellaneous driver fixes and
 enhancements

From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
Date: Mon, 26 Feb 2018 18:10:54 -0600

> There is not a general theme to this patch set other than that it
> fixes a few issues with the ibmvnic driver. I will just give a quick
> summary of what each patch does here.
> 
> "ibmvnic: Fix TX descriptor tracking again" resolves a race condition
> introduced in an earlier fix to track outstanding transmit descriptors.
> This condition can throw off the tracking counter to the point that
> a transmit queue will halt forever.
> 
> "ibmvnic: Allocate statistics buffers during probe" allocates queue
> statistics buffers on device probe to avoid a crash when accessing
> statistics of an unopened interface.
> 
> "ibmvnic: Harden TX/RX pool cleaning" includes additional checks to
> avoid a bad access when cleaning RX and TX buffer pools during a device
> reset.
> 
> "ibmvnic: Report queue stops and restarts as debug output" changes TX
> queue state notifications from informational to debug messages. This
> information is not necessarily useful to a user and under load can result
> in a lot of log output.
> 
> "ibmvnic: Do not attempt to login if RX or TX queues are not allocated"
> checks that device queues have been allocated successfully before
> attempting device login. This resolves a panic that could occur if a
> user attempted to configure a device after a failed reset.
> 
> Thanks for your attention.

Series applied, thanks Thomas.