netdev - Re: [PATCH net-next] team: Use extack to report enslavement failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180227204235.7d4ab738@redhat.com>
Date:   Tue, 27 Feb 2018 20:42:35 +0100
From:   Jiri Benc <jbenc@...hat.com>
To:     Ido Schimmel <idosch@...lanox.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        dsahern@...il.com, mlxsw@...lanox.com
Subject: Re: [PATCH net-next] team: Use extack to report enslavement
 failures

On Tue, 27 Feb 2018 17:38:08 +0200, Ido Schimmel wrote:
>  	if (port_dev->flags & IFF_LOOPBACK) {
> +		NL_SET_ERR_MSG(extack, "Loopback device can't be added as a team port");
>  		netdev_err(dev, "Device %s is loopback device. Loopback devices can't be added as a team port\n",
>  			   portname);

Aren't the netdev_errs unnecessary now?

Or do you keep them for people using old config tools with a new kernel?
If so, for how long? They should certainly be removed eventually. How
do we ensure we don't forget?

Seems to me it would be better to remove them right now.

Thanks,

 Jiri